Write about page #1104
Draft
Write about page #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit de26581. |
myieye
reviewed
Oct 7, 2024
There was a problem hiding this comment.
- I like the mention of open source 👍.
- It feels weird to mention SIL Lexical Tools by itself, because it sort of excludes Payap. We could somehow squash it into our mention of Language Technology, but I'm not sure if it's worth it.
Then it looks like you took the homescreen text and made some changes to it. Here are my observations:
- You removed WeSay. How come? I know it's old, but...
- There's a pronoun change that doesn't work: "We host..." to "It is..."
- "the Linguistics Institute..." sounds better to me. I think the article should be there.
Ultimately, I like the home page version more. I'd just take that and add your open source line. I wouldn't necessarily include the open source mention on the home page (we sure can if you'd prefer), but other than that, it would be handy if we can share the same i18n text.
|
Yeah I kinda just let AI complete it for me, so that's why it looks weird. I agree, let's just reuse the home version and update it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #854
For now I'm just going to write it in english to keep it simple. @myieye would you take a look even though it's still a draft?